Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf!: use topic selector store in subscriber #944

Merged
merged 2 commits into from
Aug 30, 2024
Merged

perf!: use topic selector store in subscriber #944

merged 2 commits into from
Aug 30, 2024

Conversation

dunglas
Copy link
Owner

@dunglas dunglas commented Aug 28, 2024 •
edited
Loading

If the string doesn't contain a {, we can consider that it's a plain string.

Better: use the TopicSelectorStore that has this optimization and a cache.

@dunglas dunglas changed the title perf: fast check for URI template in topic perf!: fast check for URI template in topic Aug 29, 2024
@dunglas dunglas changed the title perf!: fast check for URI template in topic perf!: use topic selector store in subscriber Aug 29, 2024
@dunglas dunglas merged commit ab445d3 into main Aug 30, 2024
37 of 41 checks passed
@dunglas dunglas deleted the perf/set-topics branch August 30, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dunglas